fix: correct bitwise operation in dconfig status tracking - #471
Closed
18202781743 wants to merge 1 commit into
Closed
fix: correct bitwise operation in dconfig status tracking#47118202781743 wants to merge 1 commit into
18202781743 wants to merge 1 commit into
Conversation
1. Fixed incorrect bitwise AND operation in property status tracking 2. Changed `fetchAndAndOrdered(1 << index)` to `fetchAndAndOrdered(~(1 << index))` 3. This ensures proper bit clearing when unsetting property flags 4. The change was made in both the generated header and the generator tool 5. Without this fix, status tracking would incorrectly set bits instead of clearing them fix: 修正 dconfig 状态跟踪中的位操作 1. 修复了属性状态跟踪中错误的位与操作 2. 将 `fetchAndAndOrdered(1 << index)` 改为 `fetchAndAndOrdered(~(1 << index))` 3. 确保在取消设置属性标志时能正确清除位 4. 修改同时应用于生成的头部文件和生成器工具 5. 若不修复此问题，状态跟踪会错误地设置位而非清除它们
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
deepin-ci-robot
added a commit
to linuxdeepin/dtk6core
that referenced
this pull request
May 8, 2025
Synchronize source files from linuxdeepin/dtkcore. Source-pull-request: linuxdeepin/dtkcore#471
Contributor
deepin pr auto review代码审查意见：
综上所述，代码的更改看起来是为了实现逻辑上的反转，但是需要确保这一更改是经过充分测试和验证的。同时，保持代码的注释、风格和可读性也是非常重要的。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fetchAndAndOrdered(1 << index)tofetchAndAndOrdered(~(1 << index))tool
of clearing them
fix: 修正 dconfig 状态跟踪中的位操作
fetchAndAndOrdered(1 << index)改为fetchAndAndOrdered(~(1 << index))